netdev - Re: [PATCH net] af_key: fix kernel-infoleak vs XFRMA_ALG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZAcVL3ZYGkaoFX1+@gondor.apana.org.au>
Date:   Tue, 7 Mar 2023 18:42:55 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
        eric.dumazet@...il.com, syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] af_key: fix kernel-infoleak vs XFRMA_ALG_COMP

On Tue, Mar 07, 2023 at 10:02:31AM +0000, Eric Dumazet wrote:
> When copy_to_user_state_extra() copies to netlink skb
> x->calg content, it expects calg was fully initialized.
> 
> We must make sure all unused bytes are cleared at
> allocation side.

This has already been fixed:

https://lore.kernel.org/all/Y+RH4Fv8yj0g535y@gondor.apana.org.au/

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt