[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZAh2IeS3TnyllK33@corigine.com>
Date: Wed, 8 Mar 2023 12:48:49 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: error27@...il.com, Kalle Valo <kvalo@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
P Praneesh <quic_ppranees@...cinc.com>,
Karthikeyan Periyasamy <quic_periyasa@...cinc.com>,
Jeff Johnson <quic_jjohnson@...cinc.com>,
Bhagavathi Perumal S <quic_bperumal@...cinc.com>,
Wen Gong <quic_wgong@...cinc.com>, ath12k@...ts.infradead.org,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: ath12k: Add missing unwind goto in
ath12k_pci_probe()
On Tue, Mar 07, 2023 at 02:47:06AM -0800, Harshit Mogalapalli wrote:
> Smatch Warns:
> drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe()
> warn: missing unwind goto?
>
> Store the error value in ret and use correct label with a goto.
>
> Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
> Reported-by: Dan Carpenter <error27@...il.com>
> Link: https://lore.kernel.org/all/Y+426q6cfkEdb5Bv@kili/
> Suggested-by: Dan Carpenter <error27@...il.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
> ---
> Only Compile tested, found with Smatch.
Reviewed-by: Simon Horman <simon.horman@...igine.com>
Powered by blists - more mailing lists