[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <28de6e62-5bc3-b986-b069-32150b0c81eb@ti.com>
Date: Wed, 8 Mar 2023 09:49:40 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Rob Herring <robh@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
<linux@...linux.org.uk>, <pabeni@...hat.com>,
<krzysztof.kozlowski@...aro.org>,
<krzysztof.kozlowski+dt@...aro.org>, <nsekhar@...com>,
<rogerq@...nel.org>, <netdev@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <srk@...com>,
<s-vadapalli@...com>
Subject: Re: [PATCH net-next] dt-bindings: net: ti: k3-am654-cpsw-nuss:
Document Serdes PHY
Hello Rob,
On 07/03/23 19:31, Rob Herring wrote:
> On Mon, Mar 06, 2023 at 03:17:50PM +0530, Siddharth Vadapalli wrote:
>> Update bindings to include Serdes PHY as an optional PHY, in addition to
>> the existing CPSW MAC's PHY. The CPSW MAC's PHY is required while the
>> Serdes PHY is optional. The Serdes PHY handle has to be provided only
>> when the Serdes is being configured in a Single-Link protocol. Using the
>> name "serdes-phy" to represent the Serdes PHY handle, the am65-cpsw-nuss
>> driver can obtain the Serdes PHY and request the Serdes to be
>> configured.
>>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
>> ---
>>
>> Hello,
>>
>> This patch corresponds to the Serdes PHY bindings that were missed out in
>> the series at:
>> Link: https://lore.kernel.org/r/20230104103432.1126403-1-s-vadapalli@ti.com/
>> This was pointed out at:
>> https://lore.kernel.org/r/CAMuHMdW5atq-FuLEL3htuE3t2uO86anLL3zeY7n1RqqMP_rH1g@mail.gmail.com/
>>
>> .../bindings/net/ti,k3-am654-cpsw-nuss.yaml | 21 +++++++++++++++++--
>> 1 file changed, 19 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
>> index 900063411a20..fab7df437dcc 100644
>> --- a/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
>> @@ -126,8 +126,25 @@ properties:
>> description: CPSW port number
>>
>> phys:
>> - maxItems: 1
>> - description: phandle on phy-gmii-sel PHY
>> + minItems: 1
>> + maxItems: 2
>> + description:
>> + phandle(s) on CPSW MAC's PHY (Required) and the Serdes
>> + PHY (Optional). phandle to the Serdes PHY is required
>> + when the Serdes has to be configured in Single-Link
>> + configuration.
>
> Like this:
>
> minItems: 1
> items:
> - description: CPSW MAC's PHY
> - description: Serdes PHY. Serdes PHY is required
> when the Serdes has to be configured in Single-Link
>
>> +
>> + phy-names:
>> + oneOf:
>> + - items:
>> + - const: mac-phy
>> + - const: serdes-phy
>> + - items:
>> + - const: mac-phy
>
> Drop this and use minItems in 1st 'items' entry.
>
>> + description:
>> + Identifiers for the CPSW MAC's PHY and the Serdes PHY.
>> + CPSW MAC's PHY is required and therefore "mac-phy" is
>> + required, while "serdes-phy" is optional.
>
> No need to state in plain text what the schema already says.
Thank you for reviewing the patch. I will implement your feedback and post the
v2 patch.
Regards,
Siddharth.
Powered by blists - more mailing lists