| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230308051310.12544-10-shannon.nelson@amd.com>
Date: Tue, 7 Mar 2023 21:13:06 -0800
From: Shannon Nelson <shannon.nelson@....com>
To: <shannon.nelson@....com>, <brett.creeley@....com>,
<davem@...emloft.net>, <netdev@...r.kernel.org>, <kuba@...nel.org>
CC: <drivers@...sando.io>, <leon@...nel.org>, <jiri@...nulli.us>
Subject: [PATCH RFC v4 net-next 09/13] pds_core: add auxiliary_bus devices
An auxiliary_bus device is created for each VF at VF probe and destroyed
at VF remove. The VFs are always removed on PF remove, so there should
be no issues with VFs trying to access missing PF structures.
Signed-off-by: Shannon Nelson <shannon.nelson@....com>
---
drivers/net/ethernet/amd/pds_core/Makefile | 1 +
drivers/net/ethernet/amd/pds_core/auxbus.c | 138 +++++++++++++++++++++
drivers/net/ethernet/amd/pds_core/main.c | 35 +++++-
include/linux/pds/pds_auxbus.h | 16 +++
include/linux/pds/pds_core.h | 7 ++
5 files changed, 195 insertions(+), 2 deletions(-)
create mode 100644 drivers/net/ethernet/amd/pds_core/auxbus.c
create mode 100644 include/linux/pds/pds_auxbus.h
diff --git a/drivers/net/ethernet/amd/pds_core/Makefile b/drivers/net/ethernet/amd/pds_core/Makefile
index 6d1d6c58a1fa..0abc33ce826c 100644
--- a/drivers/net/ethernet/amd/pds_core/Makefile
+++ b/drivers/net/ethernet/amd/pds_core/Makefile
@@ -5,6 +5,7 @@ obj-$(CONFIG_PDS_CORE) := pds_core.o
pds_core-y := main.o \
devlink.o \
+ auxbus.o \
dev.o \
adminq.o \
core.o \
diff --git a/drivers/net/ethernet/amd/pds_core/auxbus.c b/drivers/net/ethernet/amd/pds_core/auxbus.c
new file mode 100644
index 000000000000..535fee627874
--- /dev/null
+++ b/drivers/net/ethernet/amd/pds_core/auxbus.c
@@ -0,0 +1,138 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Copyright(c) 2023 Advanced Micro Devices, Inc */
+
+#include <linux/pds/pds_core.h>
+#include <linux/pds/pds_adminq.h>
+#include <linux/pds/pds_auxbus.h>
+
+static void pdsc_auxbus_dev_release(struct device *dev)
+{
+ struct pds_auxiliary_dev *padev =
+ container_of(dev, struct pds_auxiliary_dev, aux_dev.dev);
+
+ kfree(padev);
+}
+
+static struct pds_auxiliary_dev *pdsc_auxbus_dev_register(struct pdsc *vf,
+ struct pdsc *pf,
+ char *name)
+{
+ struct auxiliary_device *aux_dev;
+ struct pds_auxiliary_dev *padev;
+ int err;
+
+ padev = kzalloc(sizeof(*padev), GFP_KERNEL);
+ if (!padev)
+ return NULL;
+
+ padev->vf = vf;
+ padev->pf = pf;
+
+ aux_dev = &padev->aux_dev;
+ aux_dev->name = name;
+ aux_dev->id = vf->id;
+ aux_dev->dev.parent = vf->dev;
+ aux_dev->dev.release = pdsc_auxbus_dev_release;
+
+ err = auxiliary_device_init(aux_dev);
+ if (err < 0) {
+ dev_warn(vf->dev, "auxiliary_device_init of %s id %d failed: %pe\n",
+ name, vf->id, ERR_PTR(err));
+ goto err_out;
+ }
+
+ err = auxiliary_device_add(aux_dev);
+ if (err) {
+ dev_warn(vf->dev, "auxiliary_device_add of %s id %d failed: %pe\n",
+ name, vf->id, ERR_PTR(err));
+ auxiliary_device_uninit(aux_dev);
+ goto err_out;
+ }
+
+ return padev;
+
+err_out:
+ kfree(padev);
+ return NULL;
+}
+
+int pdsc_auxbus_dev_add_vf(struct pdsc *vf, struct pdsc *pf)
+{
+ struct pds_auxiliary_dev *padev;
+ enum pds_core_vif_types vt;
+ int err = 0;
+
+ mutex_lock(&pf->config_lock);
+ if (pf->state) {
+ dev_warn(vf->dev, "%s: PF in a transition state (%lu)\n",
+ __func__, pf->state);
+ err = -EBUSY;
+ } else if (!pf->vfs) {
+ dev_warn(vf->dev, "%s: PF vfs array not ready\n",
+ __func__);
+ err = -ENOTTY;
+ } else if (vf->vf_id >= pf->num_vfs) {
+ dev_warn(vf->dev, "%s: vfid %d out of range\n",
+ __func__, vf->vf_id);
+ err = -ERANGE;
+ } else if (pf->vfs[vf->vf_id].padev) {
+ dev_warn(vf->dev, "%s: vfid %d already running\n",
+ __func__, vf->vf_id);
+ err = -ENODEV;
+ }
+ if (err)
+ goto out_unlock;
+
+ pf->vfs[vf->vf_id].vf = vf;
+ for (vt = 0; vt < PDS_DEV_TYPE_MAX; vt++) {
+ u16 vt_support;
+
+ /* Verify that the type is supported and enabled */
+ vt_support = !!le16_to_cpu(pf->dev_ident.vif_types[vt]);
+ if (!(vt_support &&
+ pf->viftype_status[vt].supported &&
+ pf->viftype_status[vt].enabled))
+ continue;
+
+ padev = pdsc_auxbus_dev_register(vf, pf, pf->viftype_status[vt].name);
+ pf->vfs[vf->vf_id].padev = padev;
+
+ /* We only support a single type per VF, so jump out here */
+ break;
+ }
+
+out_unlock:
+ mutex_unlock(&pf->config_lock);
+ return err;
+}
+
+int pdsc_auxbus_dev_del_vf(struct pdsc *vf, struct pdsc *pf)
+{
+ struct pds_auxiliary_dev *padev;
+ int err = 0;
+
+ mutex_lock(&pf->config_lock);
+ if (pf->state) {
+ dev_warn(vf->dev, "%s: PF in a transition state (%lu)\n",
+ __func__, pf->state);
+ err = -EBUSY;
+ } else if (vf->vf_id >= pf->num_vfs) {
+ dev_warn(vf->dev, "%s: vfid %d out of range\n",
+ __func__, vf->vf_id);
+ err = -ERANGE;
+ }
+ if (err)
+ goto out_unlock;
+
+ padev = pf->vfs[vf->vf_id].padev;
+ if (padev) {
+ auxiliary_device_delete(&padev->aux_dev);
+ auxiliary_device_uninit(&padev->aux_dev);
+ }
+ pf->vfs[vf->vf_id].padev = NULL;
+ pf->vfs[vf->vf_id].vf = NULL;
+
+out_unlock:
+ mutex_unlock(&pf->config_lock);
+ return err;
+}
diff --git a/drivers/net/ethernet/amd/pds_core/main.c b/drivers/net/ethernet/amd/pds_core/main.c
index db260fe149ff..1a81a6de1ece 100644
--- a/drivers/net/ethernet/amd/pds_core/main.c
+++ b/drivers/net/ethernet/amd/pds_core/main.c
@@ -196,15 +196,34 @@ static int pdsc_sriov_configure(struct pci_dev *pdev, int num_vfs)
static int pdsc_init_vf(struct pdsc *pdsc)
{
+ struct pdsc *pdsc_pf;
int err;
+ pdsc_pf = pdsc_get_pf_struct(pdsc->pdev);
+ if (IS_ERR_OR_NULL(pdsc_pf))
+ return PTR_ERR(pdsc_pf) ?: -1;
+
pdsc->vf_id = pci_iov_vf_id(pdsc->pdev);
err = pdsc_dl_register(pdsc);
if (err)
return err;
- return 0;
+ err = pdsc_auxbus_dev_add_vf(pdsc, pdsc_pf);
+ if (err)
+ pdsc_dl_unregister(pdsc);
+
+ return err;
+}
+
+static void pdsc_del_vf(struct pdsc *pdsc)
+{
+ struct pdsc *pdsc_pf;
+
+ pdsc_pf = pdsc_get_pf_struct(pdsc->pdev);
+ if (IS_ERR(pdsc_pf))
+ return;
+ pdsc_auxbus_dev_del_vf(pdsc, pdsc_pf);
}
#define PDSC_WQ_NAME_LEN 24
@@ -355,7 +374,13 @@ static void pdsc_remove(struct pci_dev *pdev)
*/
pdsc_dl_unregister(pdsc);
- if (!pdev->is_virtfn) {
+ if (pdev->is_virtfn) {
+ pdsc_del_vf(pdsc);
+ } else {
+ /* Remove the VFs and their aux_bus connections before other
+ * cleanup so that the clients can use the AdminQ to cleanly
+ * shut themselves down.
+ */
pdsc_sriov_configure(pdev, 0);
mutex_lock(&pdsc->config_lock);
@@ -395,6 +420,12 @@ static struct pci_driver pdsc_driver = {
.sriov_configure = pdsc_sriov_configure,
};
+struct pdsc *pdsc_get_pf_struct(struct pci_dev *vf_pdev)
+{
+ return pci_iov_get_pf_drvdata(vf_pdev, &pdsc_driver);
+};
+EXPORT_SYMBOL_GPL(pdsc_get_pf_struct);
+
static int __init pdsc_init_module(void)
{
pdsc_debugfs_create();
diff --git a/include/linux/pds/pds_auxbus.h b/include/linux/pds/pds_auxbus.h
new file mode 100644
index 000000000000..30c643878a2b
--- /dev/null
+++ b/include/linux/pds/pds_auxbus.h
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/* Copyright(c) 2023 Advanced Micro Devices, Inc */
+
+#ifndef _PDSC_AUXBUS_H_
+#define _PDSC_AUXBUS_H_
+
+#include <linux/auxiliary_bus.h>
+
+struct pds_auxiliary_dev {
+ struct auxiliary_device aux_dev;
+ struct pdsc *vf;
+ struct pdsc *pf;
+ u16 client_id;
+ void *priv;
+};
+#endif /* _PDSC_AUXBUS_H_ */
diff --git a/include/linux/pds/pds_core.h b/include/linux/pds/pds_core.h
index 7f59b3fbe451..e6d18f219033 100644
--- a/include/linux/pds/pds_core.h
+++ b/include/linux/pds/pds_core.h
@@ -30,8 +30,11 @@ struct pdsc_dev_bar {
int res_index;
};
+struct pdsc;
+
struct pdsc_vf {
struct pds_auxiliary_dev *padev;
+ struct pdsc *vf;
u16 index;
__le16 vif_types[PDS_DEV_TYPE_MAX];
};
@@ -238,6 +241,7 @@ static inline void pds_core_dbell_ring(u64 __iomem *db_page,
writeq(val, &db_page[qtype]);
}
+struct pdsc *pdsc_get_pf_struct(struct pci_dev *vf_pdev);
void pdsc_queue_health_check(struct pdsc *pdsc);
void __iomem *pdsc_map_dbpage(struct pdsc *pdsc, int page_num);
@@ -301,6 +305,9 @@ int pdsc_start(struct pdsc *pdsc);
void pdsc_stop(struct pdsc *pdsc);
void pdsc_health_thread(struct work_struct *work);
+int pdsc_auxbus_dev_add_vf(struct pdsc *pdsc_vf, struct pdsc *pdsc_pf);
+int pdsc_auxbus_dev_del_vf(struct pdsc *pdsc_vf, struct pdsc *pdsc_pf);
+
void pdsc_process_adminq(struct pdsc_qcq *qcq);
void pdsc_work_thread(struct work_struct *work);
irqreturn_t pdsc_adminq_isr(int irq, void *data);
--
2.17.1
Powered by blists - more mailing lists