netdev - Re: [PATCH net-next] net: mvpp2: Defer probe if MAC address source is not yet ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5432f8f2da54d0ffc4e4e28fb88ac14f5bb682de.camel@redhat.com>
Date:   Thu, 09 Mar 2023 11:12:18 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Russell King <linux@...linux.org.uk>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: mvpp2: Defer probe if MAC address source
 is not yet ready

On Tue, 2023-03-07 at 20:29 +0100, Miquel Raynal wrote:
> NVMEM layouts are no longer registered early, and thus may not yet be
> available when Ethernet drivers (or any other consumer) probe, leading
> to possible probe deferrals errors. Forward the error code if this
> happens. All other errors being discarded, the driver will eventually
> use a random MAC address if no other source was considered valid (no
> functional change on this regard).
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>

The patch LGTM, but if feels like a fix more than a new feature re-
factor. Any special reason to target the net-next tree?

Thanks!

Paolo