netdev - Re: [PATCH RFC v4 net-next 03/13] pds_core: health timer and workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cdabcca-f8e8-81a8-a16c-d646adb84dac@amd.com>
Date:   Thu, 9 Mar 2023 14:26:18 -0800
From:   Shannon Nelson <shannon.nelson@....com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     brett.creeley@....com, davem@...emloft.net, netdev@...r.kernel.org,
        kuba@...nel.org, drivers@...sando.io, leon@...nel.org
Subject: Re: [PATCH RFC v4 net-next 03/13] pds_core: health timer and
 workqueue

On 3/9/23 1:30 AM, Jiri Pirko wrote:
> Thu, Mar 09, 2023 at 03:08:44AM CET, shannon.nelson@....com wrote:
>> On 3/8/23 1:39 AM, Jiri Pirko wrote:
>>> Wed, Mar 08, 2023 at 06:13:00AM CET, shannon.nelson@....com wrote:
>>>> Add in the periodic health check and the related workqueue,
>>>> as well as the handlers for when a FW reset is seen.
>>>
>>> Why don't you use devlink health to let the user know that something odd
>>> happened with HW?
>>
>> Just haven't gotten to that yet.
> 
> Please do it from start, this is exactly why devlink health was
> introduced.

I'll add it in the next rev.

sln