netdev - Re: [PATCH] net: calxeda: fix race condition in xgmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJedcCyUW7h+5AY8BRN13S3wEMXM2tv0ioxFF3nKKM88g7Zmtw@mail.gmail.com>
Date:   Thu, 9 Mar 2023 15:26:54 +0800
From:   Zheng Hacker <hackerzheng666@...il.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     Zheng Wang <zyytlz.wz@....com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        1395428693sheep@...il.com, alex000young@...il.com
Subject: Re: [PATCH] net: calxeda: fix race condition in xgmac_remove due to
 unfinshed work

Yunsheng Lin <linyunsheng@...wei.com> 于2023年3月9日周四 14:27写道：
>
> On 2023/3/9 14:23, Yunsheng Lin wrote:
> > On 2023/3/9 11:56, Zheng Wang wrote:
> >> In xgmac_probe, the priv->tx_timeout_work is bound with
> >> xgmac_tx_timeout_work. In xgmac_remove, if there is an
> >> unfinished work, there might be a race condition that
> >> priv->base was written byte after iounmap it.
> >>
> >> Fix it by finishing the work before cleanup.
> >
> > This should go to net branch, so title should be:
> >
> >  [PATCH net] net: calxeda: fix race condition in xgmac_remove due to unfinshed work
>
> typo error:
> unfinshed -> unfinished
>

Got it. Will correct it in the next version of patch.

Thanks,
Zheng