netdev - Re: [PATCH] atm: he: fix potential ioremap leak of membase in he

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230310112850.GA424646@electric-eye.fr.zoreil.com>
Date:   Fri, 10 Mar 2023 12:28:50 +0100
From:   Francois Romieu <romieu@...zoreil.com>
To:     Gencen Gan <u202011061@...il.com>
Cc:     Chas Williams <3chas3@...il.com>, Dongliang Mu <dzm91@...t.edu.cn>,
        linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] atm: he: fix potential ioremap leak of membase in he_dev

Gencen Gan <u202011061@...il.com> :
> In the function he_start() in drivers/atm/he.c, there
> is no unmapping of he_dev->membase in the branch that
> exits due to an error like reset failure, which may
> cause a memory leak.

Why would he_dev->membase not be unmapped in he_stop() ?

he_stop() is paired with he_start() as soon a he_start() returns
anything different from 0 in he_init_one(). I see no other place
where he_start() is used.

The atm_dev/he_dev pointers also seem correctly set.

-- 
Ueimor