netdev - Re: [PATCH net-next v2 1/2] net: dsa: microchip: add ksz_setup_tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230310071310.GB29822@pengutronix.de>
Date:   Fri, 10 Mar 2023 08:13:10 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Arun.Ramadoss@...rochip.com
Cc:     olteanv@...il.com, andrew@...n.ch, f.fainelli@...il.com,
        kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
        Woojung.Huh@...rochip.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, kernel@...gutronix.de
Subject: Re: [PATCH net-next v2 1/2] net: dsa: microchip: add
 ksz_setup_tc_mode() function

On Fri, Mar 10, 2023 at 04:22:34AM +0000, Arun.Ramadoss@...rochip.com wrote:
> On Fri, 2023-03-10 at 04:00 +0000, Arun Ramadoss - I17769 wrote:
> > On Wed, 2023-03-08 at 10:12 +0100, Oleksij Rempel wrote:
> > > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > > know the content is safe
> > > 
> > > Add ksz_setup_tc_mode() to make queue scheduling and shaping
> > > configuration more visible.
> > > 
> > > Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> > 
> > Acked-by: Arun Ramadoss <arun.ramadoss@...rochip.com
> > 
> 
> If the ets command is supported only in KSZ9477 series of switch, do we
> need to return Not supported for KSZ87xx/KSZ88xx switch similar to tc
> cbs implementation. I could infer from the patch set that, all the
> register set are for KSZ9477, so invoking the command in
> KSZ87xx/KSZ88xx will have undefined behaviour. Correct me if I am
> wrong.

Ack. You are correct.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |