netdev - [PATCH] Staging: qlge: Remove parenthesis around single condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230311140409.GA22831@ubuntu>
Date:   Sat, 11 Mar 2023 06:04:09 -0800
From:   Sumitra Sharma <sumitraartsy@...il.com>
To:     outreachy@...ts.linux.dev, manishc@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, coiby.xu@...il.com,
        gregkh@...uxfoundation.org, netdev@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Cc:     outreachy@...ts.linux.dev
Subject: [PATCH] Staging: qlge: Remove parenthesis around single condition

At line #354 checkpatch.pl:
CHECK: Unnecessary parentheses around 'i == 0x00000114'
CHECK: Unnecessary parentheses around 'i == 0x00000118'
CHECK: Unnecessary parenthesis around 'i == 0x00000140'
CHECK: Unnecessary parentheses around 'i == 0x0000013c'

Signed-off-by: Sumitra Sharma <sumitraartsy@...il.com>
---
 drivers/staging/qlge/qlge_dbg.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c
index 66d28358342f..b190a2993033 100644
--- a/drivers/staging/qlge/qlge_dbg.c
+++ b/drivers/staging/qlge/qlge_dbg.c
@@ -351,10 +351,10 @@ static int qlge_get_xgmac_regs(struct qlge_adapter *qdev, u32 *buf,
 		/* We're reading 400 xgmac registers, but we filter out
 		 * several locations that are non-responsive to reads.
 		 */
-		if ((i == 0x00000114) ||
-		    (i == 0x00000118) ||
-			(i == 0x0000013c) ||
-			(i == 0x00000140) ||
+		if (i == 0x00000114 ||
+		    i == 0x00000118 ||
+			i == 0x0000013c ||
+			i == 0x00000140 ||
 			(i > 0x00000150 && i < 0x000001fc) ||
 			(i > 0x00000278 && i < 0x000002a0) ||
 			(i > 0x000002c0 && i < 0x000002cf) ||
-- 
2.25.1