netdev - Re: [PATCH] Staging: qlge: Remove parenthesis around single condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.22.394.2303111547520.2802@hadrien>
Date:   Sat, 11 Mar 2023 15:49:03 +0100 (CET)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Sumitra Sharma <sumitraartsy@...il.com>
cc:     error27@...il.com, GR-Linux-NIC-Dev@...vell.com,
        coiby.xu@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        manishc@...vell.com, netdev@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] Staging: qlge: Remove parenthesis around single
 condition



On Sat, 11 Mar 2023, Sumitra Sharma wrote:

> Hi Dan,
>
> Your suggestion for correcting the indentation to
> "[tab][tab][space][space][space][space](i ==." conflicts with the
> statement "Outside of comments, documentation and except in Kconfig,
> spaces are never used for indentation" written in
> https://elixir.bootlin.com/linux/latest/source/Documentation/process/coding-style.rst

You can use spaces at the end of an indentation if it allows lining up
things with a similar purpose.

Look around at other examples of kernel code, outside of staging, to see
what others have done.

julia