netdev - Re: [PATCH net-next v3] net: phy: micrel: Add support for PTP_PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZA6LGJZ2nWunT1xE@hoboy.vegasvil.org>
Date:   Sun, 12 Mar 2023 19:31:52 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Horatiu Vultur <horatiu.vultur@...rochip.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH net-next v3] net: phy: micrel: Add support for
 PTP_PF_PEROUT for lan8841

On Fri, Mar 10, 2023 at 04:38:24PM -0800, Jakub Kicinski wrote:

> AFAICT enabling a new output will steal the event from the previous one.
> Is this normal / expected? Should you be checking if any output is
> active and refuse to enable another GPIO if so?

The PTP class layer takes care of enabling and switching of functions
among the pins.  The functions (like periodic output) and the pins are
independent.  The user may free assign functions to pins, and
re-assign them at will.

When switching, class layer ensures that the pin support the function,
and it also takes care of disabling functions to avoid weird behavior.

See ptp_disable_pinfunc and ptp_set_pinfunc in drivers/ptp/ptp_chardev.c

> Richard, does the patch look good to you?

Yes, looks reasonable, mostly hardware specific.

Thanks,
Richard