netdev - Re: [PATCH net 2/2] net/smc: Fix device de-init sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZA8Fxe8wKM5zrjNO@TONYMAC-ALIBABA.local>
Date:   Mon, 13 Mar 2023 19:15:17 +0800
From:   Tony Lu <tonylu@...ux.alibaba.com>
To:     Wenjia Zhang <wenjia@...ux.ibm.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Karsten Graul <kgraul@...ux.ibm.com>,
        Alexandra Winter <wintera@...ux.ibm.com>,
        Jan Karcher <jaka@...ux.ibm.com>,
        Stefan Raspl <raspl@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>
Subject: Re: [PATCH net 2/2] net/smc: Fix device de-init sequence

On Mon, Mar 13, 2023 at 11:08:29AM +0100, Wenjia Zhang wrote:
> From: Stefan Raspl <raspl@...ux.ibm.com>
> 
> CLC message initialization was not properly reversed in error handling path.
> 
> Reported-and-suggested-by: Alexander Gordeev <agordeev@...ux.ibm.com>
> Signed-off-by: Stefan Raspl <raspl@...ux.ibm.com>
> Signed-off-by: Wenjia Zhang <wenjia@...ux.ibm.com>

Reviewed-by: Tony Lu <tonylu@...ux.alibaba.com>

Thanks, LGTM.

> ---
>  net/smc/af_smc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index a4cccdfdc00a..50052f53a1dd 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -3498,6 +3498,7 @@ static int __init smc_init(void)
>  out_nl:
>  	smc_nl_exit();
>  out_ism:
> +	smc_clc_exit();
>  	smc_ism_exit();
>  out_pernet_subsys_stat:
>  	unregister_pernet_subsys(&smc_net_stat_ops);
> -- 
> 2.37.2