netdev - Re: [PATCH v9 2/5] wifi: nl80211: make nl80211_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZA9WGhHRqdZKBI7U@localhost.localdomain>
Date:   Mon, 13 Mar 2023 17:58:02 +0100
From:   Michal Kubiak <michal.kubiak@...el.com>
To:     Jaewan Kim <jaewan@...gle.com>
CC:     <gregkh@...uxfoundation.org>, <johannes@...solutions.net>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <kernel-team@...roid.com>, <adelva@...gle.com>
Subject: Re: [PATCH v9 2/5] wifi: nl80211: make nl80211_send_chandef
 non-static

On Mon, Mar 13, 2023 at 07:53:23AM +0000, Jaewan Kim wrote:
> Expose nl80211_send_chandef functionality for mac80211_hwsim or vendor
> netlink can use it where needed.
> 
> Signed-off-by: Jaewan Kim <jaewan@...gle.com>
> ---
> V8: Initial commit (split from other change)
> ---
>  include/net/cfg80211.h | 9 +++++++++
>  net/wireless/nl80211.c | 4 ++--
>  2 files changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index f115b2550309..bcce8e9e2aba 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h

Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>

> @@ -938,6 +938,15 @@ int cfg80211_chandef_dfs_required(struct wiphy *wiphy,
>  				  const struct cfg80211_chan_def *chandef,
>  				  enum nl80211_iftype iftype);
>  
> +/**
> + * nl80211_send_chandef - sends the channel definition.
> + * @msg: the msg to send channel definition
> + * @chandef: the channel definition to check
> + *
> + * Returns: 0 if sent the channel definition to msg, < 0 on error
> + **/
> +int nl80211_send_chandef(struct sk_buff *msg, const struct cfg80211_chan_def *chandef);
> +
>  /**
>   * ieee80211_chanwidth_rate_flags - return rate flags for channel width
>   * @width: the channel width of the channel
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 112b4bb009c8..1fd9e6545225 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -3756,8 +3756,7 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
>  	return result;
>  }
>  
> -static int nl80211_send_chandef(struct sk_buff *msg,
> -				const struct cfg80211_chan_def *chandef)
> +int nl80211_send_chandef(struct sk_buff *msg, const struct cfg80211_chan_def *chandef)
>  {
>  	if (WARN_ON(!cfg80211_chandef_valid(chandef)))
>  		return -EINVAL;
> @@ -3788,6 +3787,7 @@ static int nl80211_send_chandef(struct sk_buff *msg,
>  		return -ENOBUFS;
>  	return 0;
>  }
> +EXPORT_SYMBOL(nl80211_send_chandef);
>  
>  static int nl80211_send_iface(struct sk_buff *msg, u32 portid, u32 seq, int flags,
>  			      struct cfg80211_registered_device *rdev,
> -- 
> 2.40.0.rc1.284.g88254d51c5-goog
>