netdev - Re: [PATCH net-next] net: geneve: set IFF_POINTOPOINT with IFLA_GENEVE_INNER_PROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Mar 2023 19:42:48 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Josef Miegl <josef@...gl.cz>
Cc:     Eyal Birger <eyal.birger@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: geneve: set IFF_POINTOPOINT with
 IFLA_GENEVE_INNER_PROTO_INHERIT

On Sun, Mar 12, 2023 at 05:45:57PM +0100, Josef Miegl wrote:
> The GENEVE tunnel used with IFLA_GENEVE_INNER_PROTO_INHERIT is
> point-to-point, so set IFF_POINTOPOINT to reflect that.
> 
> Signed-off-by: Josef Miegl <josef@...gl.cz>

Reviewed-by: Simon Horman <simon.horman@...igine.com>

> ---
>  drivers/net/geneve.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
> index 32684e94eb4f..78f9d588f712 100644
> --- a/drivers/net/geneve.c
> +++ b/drivers/net/geneve.c
> @@ -1421,7 +1421,7 @@ static int geneve_configure(struct net *net, struct net_device *dev,
>  		dev->type = ARPHRD_NONE;
>  		dev->hard_header_len = 0;
>  		dev->addr_len = 0;
> -		dev->flags = IFF_NOARP;
> +		dev->flags = IFF_POINTOPOINT | IFF_NOARP;
>  	}
>  
>  	err = register_netdevice(dev);
> -- 
> 2.37.1
>