netdev - Re: [PATCH v3 net-next] net: hns3: support wake on lan configuration and query

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230313121644.5f3bf4c7@kernel.org>
Date:   Mon, 13 Mar 2023 12:16:44 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Hao Lan <lanhao@...wei.com>
Cc:     Simon Horman <simon.horman@...igine.com>, <andrew@...n.ch>,
        <davem@...emloft.net>, <alexander.duyck@...il.com>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>,
        <edumazet@...gle.com>, <pabeni@...hat.com>,
        <richardcochran@...il.com>, <shenjian15@...wei.com>,
        <netdev@...r.kernel.org>, <wangjie125@...wei.com>
Subject: Re: [PATCH v3 net-next] net: hns3: support wake on lan
 configuration and query

On Mon, 13 Mar 2023 16:05:55 +0800 Hao Lan wrote:
> Thanks for your suggestion. Generally I follow the reverse xmas tree style
> for readability. But for this case, whether it looks a bit bloated ?

It only appears so because the driver has too many indirection layers.
Add a helper to go from netdev to the local struct.

Reminder: please don't top post and trim your replies.