netdev - RE: [PATCH net-next] ethtool: add netlink support for rss set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB62665336B2FE611635CC61A3E4B99@IA1PR11MB6266.namprd11.prod.outlook.com>
Date:   Mon, 13 Mar 2023 22:34:17 +0000
From:   "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: RE: [PATCH net-next] ethtool: add netlink support for rss set



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Thursday, March 9, 2023 11:21 PM
> To: Mogilappagari, Sudheer <sudheer.mogilappagari@...el.com>
> Cc: netdev@...r.kernel.org; mkubecek@...e.cz; Samudrala, Sridhar
> <sridhar.samudrala@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>
> Subject: Re: [PATCH net-next] ethtool: add netlink support for rss set
> 
> On Thu,  9 Mar 2023 14:05:44 -0800 Sudheer Mogilappagari wrote:
> > Add netlink based support for "ethtool -X <dev>" command by
> > implementing ETHTOOL_MSG_RSS_SET netlink message. This is equivalent
> > to functionality provided via ETHTOOL_SRSSH in ioctl path. It allows
> > creation and deletion of RSS context and modifying RSS table, hash key
> > and hash function of an interface.
> >
> > Functionality is backward compatible with the one available in ioctl
> > path but enables addition of new RSS context based parameters in
> > future.
> 
> RSS contexts are somewhat under-defined, so I'd prefer to wait until we
> actually need to extend the API before going to netlink.
> I think I told you as much when you posted initial code for RSS?
> 

Hi Jakub, we are making these changes based on below discussion:
https://lore.kernel.org/netdev/0402fc4f-21c9-eded-bed7-fd82a069ca70@intel.com/
Our thinking was to move existing functionality to netlink first and then
add new parameter (inline-flow-steering). Hence the reason for sending RSS_GET 
first and now RSS_SET. Are you suggesting that new parameter changes be sent
together with this patch-set ? 

> > diff --git a/include/uapi/linux/ethtool_netlink.h
> > b/include/uapi/linux/ethtool_netlink.h
> > index d39ce21381c5..56c4e8570dc6 100644
> > --- a/include/uapi/linux/ethtool_netlink.h
> > +++ b/include/uapi/linux/ethtool_netlink.h
> > @@ -52,6 +52,7 @@ enum {
> >  	ETHTOOL_MSG_PSE_GET,
> >  	ETHTOOL_MSG_PSE_SET,
> >  	ETHTOOL_MSG_RSS_GET,
> > +	ETHTOOL_MSG_RSS_SET,
> >  	ETHTOOL_MSG_PLCA_GET_CFG,
> >  	ETHTOOL_MSG_PLCA_SET_CFG,
> >  	ETHTOOL_MSG_PLCA_GET_STATUS,
> 
> You certainly can't add entries half way thru an enum in uAPI..

Will fix this.