netdev - Re: [PATCH net] net: ethernet: fix use after free bug in ns83820_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230313162630.225f6a86@kernel.org>
Date:   Mon, 13 Mar 2023 16:26:30 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zheng Wang <zyytlz.wz@....com>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        hackerzheng666@...il.com, 1395428693sheep@...il.com,
        alex000young@...il.com
Subject: Re: [PATCH net]  net: ethernet: fix use after free bug in
 ns83820_remove_one due to race condition

On Thu,  9 Mar 2023 17:42:31 +0800 Zheng Wang wrote:
> +	cancel_work_sync(&dev->tq_refill);
>  	ns83820_disable_interrupts(dev); /* paranoia */
>  
>  	unregister_netdev(ndev);

Canceling the work before unregister can't work.
Please take a closer look, the work to refill a ring should be
canceled when the ring itself is dismantled.