netdev - Re: [PATCH net] iavf: fix hang on reboot with ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZA7pqdS04x0T7ExN@localhost.localdomain>
Date:   Mon, 13 Mar 2023 10:15:21 +0100
From:   Michal Kubiak <michal.kubiak@...el.com>
To:     Stefan Assmann <sassmann@...nic.de>
CC:     <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
        <anthony.l.nguyen@...el.com>, <patryk.piotrowski@...el.com>,
        <slawomirx.laba@...el.com>
Subject: Re: [PATCH net] iavf: fix hang on reboot with ice

On Mon, Mar 13, 2023 at 07:48:52AM +0100, Stefan Assmann wrote:
> 
> Hi Michal,
> 
> is it okay to add this change in a follow-up patch? I'd like to get this
> patch merged quickly since we have a customer being blocked by this
> issue.
> 
> Thanks!
> 
>   Stefan


Hi Stefan,

I think it is OK.
Moreover, I consulted that idea with Slawomir Laba - the author of that loop.
It seems adding a timeout needs a further investigation. Slawomir claims
that adding that timeout may cause some side effects in other corner cases,
so for now let's leave your patch as it is.
Thank you for fixing it!

Thanks,
Michal

Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>