netdev - Re: [PATCH net] veth: rely on rtnl_dereference() instead of on rcu_dereference() in veth_set_xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a6f95c4-14bd-fc83-3a36-49eedd4442aa@tessares.net>
Date:   Tue, 14 Mar 2023 10:58:12 +0100
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, lorenzo.bianconi@...hat.com
Subject: Re: [PATCH net] veth: rely on rtnl_dereference() instead of on
 rcu_dereference() in veth_set_xdp_features()

Hi Lorenzo,

On 14/03/2023 00:08, Lorenzo Bianconi wrote:
> Fix the following kernel warning in veth_set_xdp_features routine
> relying on rtnl_dereference() instead of on rcu_dereference():

Thank you for the formal patch!

If needed:

Tested-by: Matthieu Baerts <matthieu.baerts@...sares.net>

(...)

> Fixes: fccca038f300 ("veth: take into account device reconfiguration for xdp_features flag")
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> Link: https://lore.kernel.org/netdev/cover.1678364612.git.lorenzo@kernel.org/T/#me4c9d8e985ec7ebee981cfdb5bc5ec651ef4035d

Just in case we want shorter links -- I know some people prefer them,
I'm not sure here in fact -- we can also use the "permalink":

Link:
https://lore.kernel.org/all/f5167659-99d7-04a1-2175-60ff1dabae71@tessares.net/

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net