netdev - Re: [PATCH iproute2 1/2] Revert "tc: m_action: fix parsing of TCA_EXT_WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 13:10:03 +0100
From:   Andrea Claudi <aclaudi@...hat.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev@...r.kernel.org, Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Davide Caratti <dcaratti@...hat.com>,
        Pedro Tammela <pctammela@...atatu.com>,
        Marcelo Leitner <mleitner@...hat.com>,
        Phil Sutter <psutter@...hat.com>
Subject: Re: [PATCH iproute2 1/2] Revert "tc: m_action: fix parsing of
 TCA_EXT_WARN_MSG"

On Tue, Mar 14, 2023 at 03:04:49PM +0800, Hangbin Liu wrote:
> This reverts commit 70b9ebae63ce7e6f9911bdfbcf47a6d18f24159a.
> 
> The TCA_EXT_WARN_MSG is not sit within the TCA_ACT_TAB hierarchy. It's
> belong to the TCA_MAX namespace. I will fix the issue in another patch.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  tc/m_action.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tc/m_action.c b/tc/m_action.c
> index 6c91af2c..0400132c 100644
> --- a/tc/m_action.c
> +++ b/tc/m_action.c
> @@ -586,7 +586,7 @@ int print_action(struct nlmsghdr *n, void *arg)
>  
>  	open_json_object(NULL);
>  	tc_dump_action(fp, tb[TCA_ACT_TAB], tot_acts ? *tot_acts:0, false);
> -	print_ext_msg(&tb[TCA_ACT_TAB]);
> +	print_ext_msg(tb);
>  	close_json_object();
>  
>  	return 0;
> -- 
> 2.38.1
>

As this patchset misses the cover letter, this covers patch 2/2 as
well.

Reviewed-by: Andrea Claudi <aclaudi@...hat.com>