netdev - Re: [PATCH net v3 1/1] ice: avoid bonding causing auxiliary plug/unplug under RTNL lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230314125407.GD36557@unreal>
Date:   Tue, 14 Mar 2023 14:54:07 +0200
From:   Leon Romanovsky <leonro@...dia.com>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <netdev@...r.kernel.org>,
        Dave Ertman <david.m.ertman@...el.com>,
        <shiraz.saleem@...el.com>, <mustafa.ismail@...el.com>,
        <jgg@...dia.com>, <linux-rdma@...r.kernel.org>, <poros@...hat.com>,
        <ivecera@...hat.com>, <jaroslav.pulchart@...ddata.com>,
        <git@...alerite.org>, <stable@...r.kernel.org>,
        Arpana Arland <arpanax.arland@...el.com>
Subject: Re: [PATCH net v3 1/1] ice: avoid bonding causing auxiliary
 plug/unplug under RTNL lock

On Fri, Mar 10, 2023 at 11:48:33AM -0800, Tony Nguyen wrote:
> From: Dave Ertman <david.m.ertman@...el.com>
> 
> RDMA is not supported in ice on a PF that has been added to a bonded
> interface. To enforce this, when an interface enters a bond, we unplug
> the auxiliary device that supports RDMA functionality.  This unplug
> currently happens in the context of handling the netdev bonding event.
> This event is sent to the ice driver under RTNL context.  This is causing
> a deadlock where the RDMA driver is waiting for the RTNL lock to complete
> the removal.
> 
> Defer the unplugging/re-plugging of the auxiliary device to the service
> task so that it is not performed under the RTNL lock context.
> 
> Cc: stable@...r.kernel.org # 6.1.x
> Reported-by: Jaroslav Pulchart <jaroslav.pulchart@...ddata.com>
> Link: https://lore.kernel.org/netdev/CAK8fFZ6A_Gphw_3-QMGKEFQk=sfCw1Qmq0TVZK3rtAi7vb621A@mail.gmail.com/
> Fixes: 5cb1ebdbc434 ("ice: Fix race condition during interface enslave")
> Fixes: 4eace75e0853 ("RDMA/irdma: Report the correct link speed")
> Signed-off-by: Dave Ertman <david.m.ertman@...el.com>
> Tested-by: Arpana Arland <arpanax.arland@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
> Note:
> This was reported as still causing issues [1], however, with details from
> the reporter we have not been able to reproduce the issue; a newer
> firmware was reported to fix their problem [2]. As this fixes the bug for
> other users [3][4], I'm submitting this patch.
> 
> v3:
> - Add Tested-by
> 
> v2: https://lore.kernel.org/netdev/20230217004201.2895321-1-anthony.l.nguyen@intel.com/
>  (Removed from original pull request)
> - Reversed order of bit processing in ice_service_task for PLUG/UNPLUG
> 
> v1: https://lore.kernel.org/netdev/20230131213703.1347761-2-anthony.l.nguyen@intel.com/
> 
> [1] https://lore.kernel.org/intel-wired-lan/ygay1oxikvo.fsf@localhost/
> [2] https://lore.kernel.org/intel-wired-lan/ygattz3tjk9.fsf@localhost/
> [3] https://lore.kernel.org/netdev/CAK8fFZ5Jjh-ZXfLdupQGqvb9pg7nW-6fWMN3cPMdmQQfQRLGFA@mail.gmail.com/
> [4] https://lore.kernel.org/intel-wired-lan/16c393e17c552cbf0c3456194456d32ea8bc826a.camel@redhat.com/
> 
>  drivers/net/ethernet/intel/ice/ice.h      | 14 +++++---------
>  drivers/net/ethernet/intel/ice/ice_main.c | 19 ++++++++-----------
>  2 files changed, 13 insertions(+), 20 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>