netdev - [PATCH net 0/4] net: set 'mac_managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230314131443.46342-1-wsa+renesas@sang-engineering.com>
Date:   Tue, 14 Mar 2023 14:14:38 +0100
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     netdev@...r.kernel.org
Cc:     linux-renesas-soc@...r.kernel.org, kernel@...gutronix.de,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH net 0/4] net: set 'mac_managed_pm' at probe time

When suspending/resuming an interface which was not up, we saw mdiobus
related PM handling despite 'mac_managed_pm' being set for RAVB/SH_ETH.
Heiner kindly suggested the fix to set this flag at probe time, not at
init/open time. I implemented his suggestion and it works fine on these
two Renesas drivers. These are patches 1+2.

I then looked which other drivers could be affected by the same problem.
I could only identify two where I am quite sure. Because I don't have
any HW, I opted to at least add a FIXME and send this out as patches
3+4. Ideally, they will never need to go upstream because the relevant
people will see their patch and do something like I did for patches 1+2.

Looking forward to comments. Thanks and happy hacking!

Wolfram Sang (4):
  ravb: avoid PHY being resumed when interface is not up
  sh_eth: avoid PHY being resumed when interface is not up
  fec: add FIXME to move 'mac_managed_pm' to probe
  smsc911x: add FIXME to move 'mac_managed_pm' to probe

 drivers/net/ethernet/freescale/fec_main.c |  1 +
 drivers/net/ethernet/renesas/ravb_main.c  | 12 ++++++++++--
 drivers/net/ethernet/renesas/sh_eth.c     | 12 ++++++++++--
 drivers/net/ethernet/smsc/smsc911x.c      |  1 +
 4 files changed, 22 insertions(+), 4 deletions(-)

-- 
2.30.2