netdev - Re: [PATCH net v2 4/4] selftests: bonding: add tests for ether type changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBCNC+EWSprrFTVo@localhost.localdomain>
Date:   Tue, 14 Mar 2023 16:04:43 +0100
From:   Michal Kubiak <michal.kubiak@...el.com>
To:     Nikolay Aleksandrov <razor@...ckwall.org>
CC:     <netdev@...r.kernel.org>, <monis@...taire.com>,
        <syoshida@...hat.com>, <j.vosburgh@...il.com>,
        <andy@...yhouse.net>, <kuba@...nel.org>, <davem@...emloft.net>,
        <pabeni@...hat.com>, <edumazet@...gle.com>,
        <syzbot+9dfc3f3348729cc82277@...kaller.appspotmail.com>
Subject: Re: [PATCH net v2 4/4] selftests: bonding: add tests for ether type
 changes

On Tue, Mar 14, 2023 at 01:14:26PM +0200, Nikolay Aleksandrov wrote:
> Add new network selftests for the bonding device which exercise the ether
> type changing call paths. They also test for the recent syzbot bug[1] which
> causes a warning and results in wrong device flags (IFF_SLAVE missing).
> The test adds three bond devices and a nlmon device, enslaves one of the
> bond devices to the other and then uses the nlmon device for successful
> and unsuccesful enslaves both of which change the bond ether type. Thus
> we can test for both MASTER and SLAVE flags at the same time.
> 
> If the flags are properly restored we get:
> TEST: Change ether type of an enslaved bond device with unsuccessful enslave   [ OK ]
> TEST: Change ether type of an enslaved bond device with successful enslave   [ OK ]
> 
> [1] https://syzkaller.appspot.com/bug?id=391c7b1f6522182899efba27d891f1743e8eb3ef
> 
> Signed-off-by: Nikolay Aleksandrov <razor@...ckwall.org>


Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>

Thanks,
Michal