netdev - Re: [PATCH net v2 1/4] bonding: add bond_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f78b6206-fc16-44f6-e396-b7670f1fe9b9@blackwall.org>
Date:   Tue, 14 Mar 2023 17:12:25 +0200
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Michal Kubiak <michal.kubiak@...el.com>
Cc:     netdev@...r.kernel.org, monis@...taire.com, syoshida@...hat.com,
        j.vosburgh@...il.com, andy@...yhouse.net, kuba@...nel.org,
        davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        syzbot+9dfc3f3348729cc82277@...kaller.appspotmail.com
Subject: Re: [PATCH net v2 1/4] bonding: add bond_ether_setup helper

On 14/03/2023 17:08, Nikolay Aleksandrov wrote:
> On 14/03/2023 16:58, Michal Kubiak wrote:
>> On Tue, Mar 14, 2023 at 01:14:23PM +0200, Nikolay Aleksandrov wrote:
>>> Add bond_ether_setup helper which will be used in the following patches
>>> to fix all ether_setup() calls in the bonding driver. It takes care of both
>>> IFF_MASTER and IFF_SLAVE flags, the former is always restored and the
>>> latter only if it was set.
>>>
>>> Fixes: e36b9d16c6a6d ("bonding: clean muticast addresses when device changes type")
>>> Fixes: 7d5cd2ce5292 ("bonding: correctly handle bonding type change on enslave failure")
>>> Signed-off-by: Nikolay Aleksandrov <razor@...ckwall.org>
>>> ---
>>>  drivers/net/bonding/bond_main.c | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>>
[snip]
>> Please add your function in the patch where you actually use it.
>>
> 
> I'm adding the helper in a separate patch to emphasize it and focus the review.
> I have written in the commit message that the next two fixes will be using it.
> IMO, this should be ok.
> 

Also since both fixes are for different commits this should be backportable
for both, that makes it easier to pick if only one of the two would be ported to a
specific version (i.e. the first fix is for a commit from 2009, second 2015).

Cheers,
 Nik