netdev - Re: [PATCH v2] can: rcar_canfd: Improve error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVAH9U196oCcxPsUT-z0qk4ZBkx8+nGqrJN14q8uGsQFQ@mail.gmail.com>
Date:   Tue, 14 Mar 2023 17:26:55 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Simon Horman <simon.horman@...igine.com>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v2] can: rcar_canfd: Improve error messages

Hi Simon,

On Tue, Mar 14, 2023 at 4:51 PM Simon Horman <simon.horman@...igine.com> wrote:
> On Tue, Mar 14, 2023 at 10:00:26AM +0100, Geert Uytterhoeven wrote:
> > Improve printed error messages:
> >   - Replace numerical error codes by mnemotechnic error codes, to
> >     improve the user experience in case of errors,
> >   - Drop parentheses around printed numbers, cfr.
> >     Documentation/process/coding-style.rst,
> >   - Drop printing of an error message in case of out-of-memory, as the
> >     core memory allocation code already takes care of this.
> >
> > Suggested-by: Vincent Mailhol <mailhol.vincent@...adoo.fr>
>
> you forgot to sign-off.

Thanks!

Checkpatch told me, I amended the commit, but forgot to re-run
git format-patch :-( Sorry for that, and stay tuned...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds