netdev - Re: [PATCH RESEND net-next v4 2/4] sfc: allow insertion of filters for unicast PTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 16:28:37 +0000
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Íñigo Huguet <ihuguet@...hat.com>,
        habetsm.xilinx@...il.com, richardcochran@...il.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        Yalin Li <yalli@...hat.com>
Subject: Re: [PATCH RESEND net-next v4 2/4] sfc: allow insertion of filters
 for unicast PTP

On 14/03/2023 10:09, Íñigo Huguet wrote:
> Add a second list for unicast filters and generalize the
> efx_ptp_insert/remove_filters functions to allow acting in any of the 2
> lists.
> 
> No filters for unicast are inserted yet. That will be done in the next
> patch.
> 
> The reason to use 2 different lists instead of a single one is that, in
> next patches, we will want to check if unicast filters are already added
> and if they're expired. We don't need that for multicast filters.
> 
> Reported-by: Yalin Li <yalli@...hat.com>
> Signed-off-by: Íñigo Huguet <ihuguet@...hat.com>

Acked-by: Edward Cree <ecree.xilinx@...il.com>

> -static void efx_ptp_remove_multicast_filters(struct efx_nic *efx)
> +static void efx_ptp_remove_filters(struct efx_nic *efx,
> +				   struct list_head *ptp_list)

Personally I'd name these something like filter_list rather than
 ptp_list, but no need to respin just for that.