netdev - Re: [PATCH] xfrm: Remove inner/outer modes from input path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBGmjdCkUw8wNMWL@gauss3.secunet.de>
Date:   Wed, 15 Mar 2023 12:05:49 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     <netdev@...r.kernel.org>, David George <David.George@...hos.com>
Subject: Re: [PATCH] xfrm: Remove inner/outer modes from input path

On Fri, Mar 10, 2023 at 05:26:05PM +0800, Herbert Xu wrote:
> The inner/outer modes were added to abstract out common code that
> were once duplicated between IPv4 and IPv6.  As time went on the
> abstractions have been removed and we are now left with empty
> shells that only contain duplicate information.  These can be
> removed one-by-one as the same information is already present
> elsewhere in the xfrm_state object.
> 
> Removing them from the input path actually allows certain valid
> combinations that are currently disallowed.  In particular, when
> a transport mode SA sits beneath a tunnel mode SA that changes
> address families, at present the transport mode SA cannot have
> AF_UNSPEC as its selector because it will be erroneously be treated
> as inter-family itself even though it simply sits beneath one.
> 
> This is a serious problem because you can't set the selector to
> non-AF_UNSPEC either as that will cause the selector match to
> fail as we always match selectors to the inner-most traffic.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied to ipsec-next, thanks a lot Herbert!