[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6c9ca856-1749-9884-9852-6c19a15d2f68@gmail.com>
Date: Wed, 15 Mar 2023 14:01:23 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
edward.cree@....com
Cc: linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org,
pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
habetsm.xilinx@...il.com
Subject: Re: [PATCH net-next 4/5] sfc: add code to register and unregister
encap matches
On 15/03/2023 09:43, Michal Swiatkowski wrote:
> On Tue, Mar 14, 2023 at 05:35:24PM +0000, edward.cree@....com wrote:
>> +static int efx_tc_flower_record_encap_match(struct efx_nic *efx,
>> + struct efx_tc_match *match,
>> + enum efx_encap_type type,
>> + struct netlink_ext_ack *extack)
>> +{
>> + struct efx_tc_encap_match *encap, *old;
>> + unsigned char ipv;
> int? or even boolean is_ipv4
...
>> + default: /* can't happen */
>> + NL_SET_ERR_MSG_FMT_MOD(extack, "Egress encap match on bad IP version %d",
>> + ipv);
>> + rc = -EOPNOTSUPP;
>> + goto fail_allocated;
> I will rewrite it to if. You will get rid of this unreachable code.
Yeah, that's probably better. Will do.
Powered by blists - more mailing lists