netdev - Re: [PATCH net 2/2] net/sched: act_api: add specific EXT_WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoM=ARa2rqkS8tcv23RR4q-bjWuJoeD7etijQPeY2MmW0eg@mail.gmail.com>
Date:   Wed, 15 Mar 2023 14:47:51 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Davide Caratti <dcaratti@...hat.com>,
        Pedro Tammela <pctammela@...atatu.com>,
        Marcelo Leitner <mleitner@...hat.com>,
        Phil Sutter <psutter@...hat.com>
Subject: Re: [PATCH net 2/2] net/sched: act_api: add specific EXT_WARN_MSG for
 tc action

On Wed, Mar 15, 2023 at 5:40 AM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> On Wed, Mar 15, 2023 at 12:45:32AM -0700, Jakub Kicinski wrote:
> > On Tue, 14 Mar 2023 14:58:02 +0800 Hangbin Liu wrote:
> > > --- a/include/uapi/linux/rtnetlink.h
> > > +++ b/include/uapi/linux/rtnetlink.h
> > > @@ -789,6 +789,7 @@ enum {
> > >     TCA_ROOT_FLAGS,
> > >     TCA_ROOT_COUNT,
> > >     TCA_ROOT_TIME_DELTA, /* in msecs */
> > > +   TCA_ACT_EXT_WARN_MSG,
> >
> > Not TCA_ROOT_EXT_... ?
> > All other attrs in this set are called TCA_ROOT_x
>
> Hmm, when we discussed this issue, Jamal suggested to use TCAA_EXT_WARN_MSG.
> I expand it to TCA_ACT_EXT_WARN_MSG to correspond with the format of TCA_*.
> But your suggest TCA_ROOT_EXT_ also makes sense. I'm OK to change it.
>
> Jamal, what do you think?

Yeah, sticking to the TCA_ROOT_ prefixes makes it neater. TCA_ROOT_EXT_WARN_MSG?

cheers,
jamal