netdev - Re: [patch V2 1/4] net: dst: Prevent false sharing vs. dst_entry::_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJUE3De9t3Vf-H6K+DAscEM98VZU4FaVCEOhE0ULUz9hQ@mail.gmail.com>
Date:   Wed, 15 Mar 2023 13:47:39 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Ahern <dsahern@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [patch V2 1/4] net: dst: Prevent false sharing vs. dst_entry::__refcnt

On Wed, Mar 15, 2023 at 1:37 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue,  7 Mar 2023 13:57:42 +0100 (CET) Thomas Gleixner wrote:
> > Move the rt[6i]_uncached[_list] members out of struct rtable and struct
> > rt6_info into struct dst_entry to provide padding and move the lwtstate
> > member after that so it ends up in the same cache line.
>
> Eric, David, looks reasonable?

Yes indeed, thanks for the heads up

Reviewed-by: Eric Dumazet <edumazet@...gle.com>