netdev - Re: [PATCH 1/3] net: mvpp2: classifier flow remove tagged

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Mar 2023 23:58:53 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sven Auhagen <Sven.Auhagen@...eatech.de>
Cc:     netdev@...r.kernel.org, mw@...ihalf.com, linux@...linux.org.uk,
        davem@...emloft.net, maxime.chevallier@...tlin.com
Subject: Re: [PATCH 1/3] net: mvpp2: classifier flow remove tagged

On Sat, 11 Mar 2023 08:09:48 +0100 Sven Auhagen wrote:
> The classifier attribute MVPP22_CLS_HEK_TAGGED
> has no effect in the definition and is filtered out by default.

filtered out in the code somewhere? 

> Even if it is applied to the classifier, it would discard double
> or tripple tagged vlans.

So the MVPP22_CLS_HEK_TAGGED change is a nop?

> Also add missing IP Fragmentation Flag.

What's the impact of this change? Seems like it should be a separate
patch.