netdev - Re: [STABLE REQUEST] tipc: improve function tipc_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Mar 2023 08:24:05 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lee Jones <lee@...nel.org>
Cc:     Tung Nguyen <tung.q.nguyen@...tech.com.au>, stable@...r.kernel.org,
        davem@...emloft.net, netdev@...r.kernel.org,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [STABLE REQUEST] tipc: improve function tipc_wait_for_cond()

On Tue, Mar 14, 2023 at 06:04:30PM +0000, Lee Jones wrote:
> On Tue, 14 Mar 2023, Greg KH wrote:
> 
> > On Tue, Mar 14, 2023 at 05:45:37PM +0000, Lee Jones wrote:
> > > Dear Stable,
> > >
> > > > Commit 844cf763fba6 ("tipc: make macro tipc_wait_for_cond() smp safe")
> > > > replaced finish_wait() with remove_wait_queue() but still used
> > > > prepare_to_wait(). This causes unnecessary conditional
> > > > checking  before adding to wait queue in prepare_to_wait().
> > > >
> > > > This commit replaces prepare_to_wait() with add_wait_queue()
> > > > as the pair function with remove_wait_queue().
> > > >
> > > > Acked-by: Ying Xue <ying.xue@...driver.com>
> > > > Acked-by: Jon Maloy <jon.maloy@...csson.com>
> > > > Signed-off-by: Tung Nguyen <tung.q.nguyen@...tech.com.au>
> > > > ---
> > > >  net/tipc/socket.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> > > > index 1217c90a363b..81b87916a0eb 100644
> > > > --- a/net/tipc/socket.c
> > > > +++ b/net/tipc/socket.c
> > > > @@ -388,7 +388,7 @@ static int tipc_sk_sock_err(struct socket *sock, long *timeout)
> > > >  		rc_ = tipc_sk_sock_err((sock_), timeo_);		       \
> > > >  		if (rc_)						       \
> > > >  			break;						       \
> > > > -		prepare_to_wait(sk_sleep(sk_), &wait_, TASK_INTERRUPTIBLE);    \
> > > > +		add_wait_queue(sk_sleep(sk_), &wait_);                         \
> > > >  		release_sock(sk_);					       \
> > > >  		*(timeo_) = wait_woken(&wait_, TASK_INTERRUPTIBLE, *(timeo_)); \
> > > >  		sched_annotate_sleep();				               \
> > >
> > > Could we have this ol' classic backported to v4.19 and v4.14 please?
> >
> > What is the git commit id?
> 
> Sorry, it's 223b7329ec6a0.

Now queued up, thanks.

greg k-h