netdev - Re: [PATCH next] wifi: iwlwifi: Avoid disabling GCC specific flag with clang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9a4671bef0ad931a79c2911986286f1d9bb3ae9.camel@sipsolutions.net>
Date:   Thu, 16 Mar 2023 08:52:50 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Nathan Chancellor <nathan@...nel.org>, gregory.greenman@...el.com
Cc:     kvalo@...nel.org, ndesaulniers@...gle.com, trix@...hat.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        patches@...ts.linux.dev
Subject: Re: [PATCH next] wifi: iwlwifi: Avoid disabling GCC specific flag
 with clang

On Wed, 2023-03-15 at 20:28 -0700, Nathan Chancellor wrote:
> Clang errors:
> 
>   drivers/net/wireless/intel/iwlwifi/iwl-devtrace.c:15:32: error: unknown warning group '-Wsuggest-attribute=format', ignored [-Werror,-Wunknown-warning-option]
>   #pragma GCC diagnostic ignored "-Wsuggest-attribute=format"
>                                  ^
>   1 error generated.

Oops.

> The warning being disabled by this pragma is GCC specific. Guard its use
> with CONFIG_CC_IS_GCC so that it is not used with clang to clear up the
> error.
> 

Thanks.

johannes