[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9038dba0-6f72-44a1-9f57-1c08b03b9c31@linaro.org>
Date: Thu, 16 Mar 2023 09:03:52 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Guo Samin <samin.guo@...rfivetech.com>,
linux-riscv@...ts.infradead.org, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Emil Renner Berthing <kernel@...il.dk>,
Richard Cochran <richardcochran@...il.com>,
Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Peter Geis <pgwipeout@...il.com>,
Yanhong Wang <yanhong.wang@...rfivetech.com>,
Tommaso Merciai <tomm.merciai@...il.com>
Subject: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac
On 16/03/2023 09:02, Guo Samin wrote:
>
>
> -------- 原始信息 --------
> 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 收件人: Samin Guo <samin.guo@...rfivetech.com>, linux-riscv@...ts.infradead.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
> 日期: 2023/3/16
>
>> On 16/03/2023 05:37, Samin Guo wrote:
>>> From: Yanhong Wang <yanhong.wang@...rfivetech.com>
>>>
>>> Add documentation to describe StarFive dwmac driver(GMAC).
>>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>> Signed-off-by: Yanhong Wang <yanhong.wang@...rfivetech.com>
>>> Signed-off-by: Samin Guo <samin.guo@...rfivetech.com>
>>> Tested-by: Tommaso Merciai <tomm.merciai@...il.com>
>>> ---
>>> .../devicetree/bindings/net/snps,dwmac.yaml | 1 +
>>> .../bindings/net/starfive,jh7110-dwmac.yaml | 130 ++++++++++++++++++
>>> MAINTAINERS | 6 +
>>> 3 files changed, 137 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>> index e4519cf722ab..245f7d713261 100644
>>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>>> @@ -91,6 +91,7 @@ properties:
>>> - snps,dwmac-5.20
>>> - snps,dwxgmac
>>> - snps,dwxgmac-2.10
>>> + - starfive,jh7110-dwmac
>>>
>>> reg:
>>> minItems: 1
>>> diff --git a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
>>> new file mode 100644
>>> index 000000000000..b59e6bd8201f
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
>>> @@ -0,0 +1,130 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +# Copyright (C) 2022 StarFive Technology Co., Ltd.
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/net/starfive,jh7110-dwmac.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: StarFive JH7110 DWMAC glue layer
>>> +
>>> +maintainers:
>>> + - Emil Renner Berthing <kernel@...il.dk>
>>> + - Samin Guo <samin.guo@...rfivetech.com>
>>> +
>>> +select:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - starfive,jh7110-dwmac
>>> + required:
>>> + - compatible
>>> +
>>> +properties:
>>> + compatible:
>>> + items:
>>> + - enum:
>>> + - starfive,jh7110-dwmac
>>> + - const: snps,dwmac-5.20
>>> +
>>
>> reg:
>> maxItems: 1
>
>>
>>> + clocks:
>>> + items:
>>> + - description: GMAC main clock
>>> + - description: GMAC AHB clock
>>> + - description: PTP clock
>>> + - description: TX clock
>>> + - description: GTX clock
>>> +
>>> + clock-names:
>>> + items:
>>> + - const: stmmaceth
>>> + - const: pclk
>>> + - const: ptp_ref
>>> + - const: tx
>>> + - const: gtx
>>> +
>>
>> interrupts: ???
>>
>
> Hi Krzysztof,
>
> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes,
> and the JH7110 SoC is also applicable.
> Maybe just add reg/interrupt/interrupt-names to the required ?
You need to constrain them.
>
>
> required:
> - compatible
> + - reg
> - clocks
> - clock-names
> + - interrupts
> + - interrupt-names
> - resets
> - reset-names
Best regards,
Krzysztof
Powered by blists - more mailing lists