[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZBLPK0loejiHEoe5@localhost.localdomain>
Date: Thu, 16 Mar 2023 09:11:23 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Kurt Kanzenbach <kurt@...utronix.de>,
Andrew Lunn <andrew@...n.ch>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v6 1/1] net: dsa: hellcreek: Get rid of custom
led_init_default_state_get()
On Wed, Mar 15, 2023 at 03:16:42PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 15, 2023 at 06:57:37AM +0100, Michal Swiatkowski wrote:
> > On Tue, Mar 14, 2023 at 08:18:24PM +0200, Andy Shevchenko wrote:
> > > LED core provides a helper to parse default state from firmware node.
> > > Use it instead of custom implementation.
>
> ...
>
> > You have to fix implict declaration of the led_init_default_state_get().
>
> Seems like users have to choose between 'select NEW_LEDS' and
> 'depends on NEW_LEDS' in the Kconfig.
>
> > I wonder if the code duplication here can be avoided:
>
> Whether or not this is out of the scope of this patch.
> Feel free to submit one :-)
>
> ...
>
Reasonable ;)
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> > Only suggestion, patch looks good.
>
> Thank you!
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Powered by blists - more mailing lists