netdev - Re: [PATCH net] hsr: ratelimit only when errors are printed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <261a7bca8f0f1f78e85d79a7be27cd809c956464.camel@microchip.com>
Date:   Thu, 16 Mar 2023 10:35:11 +0100
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     Matthieu Baerts <matthieu.baerts@...sares.net>,
        <mptcp@...ts.linux.dev>, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Kristian Overskeid <koverskeid@...il.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] hsr: ratelimit only when errors are printed

Hi Mattieu,

Looks good to me.

Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

On Wed, 2023-03-15 at 21:25 +0100, Matthieu Baerts wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Recently, when automatically merging -net and net-next in MPTCP devel
> tree, our CI reported [1] a conflict in hsr, the same as the one
> reported by Stephen in netdev [2].
> 
> When looking at the conflict, I noticed it is in fact the v1 [3] that
> has been applied in -net and the v2 [4] in net-next. Maybe the v1 was
> applied by accident.
> 
> As mentioned by Jakub Kicinski [5], the new condition makes more sense
> before the net_ratelimit(), not to update net_ratelimit's state which is
> unnecessary if we're not going to print either way.
> 
> Here, this modification applies the v2 but in -net.
> 
> Link: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/4423171069 [1]
> Link: https://lore.kernel.org/netdev/20230315100914.53fc1760@canb.auug.org.au/ [2]
> Link: https://lore.kernel.org/netdev/20230307133229.127442-1-koverskeid@gmail.com/ [3]
> Link: https://lore.kernel.org/netdev/20230309092302.179586-1-koverskeid@gmail.com/ [4]
> Link: https://lore.kernel.org/netdev/20230308232001.2fb62013@kernel.org/ [5]
> Fixes: 28e8cabe80f3 ("net: hsr: Don't log netdev_err message on unknown prp dst node")
> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>
> ---
>  net/hsr/hsr_framereg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/hsr/hsr_framereg.c b/net/hsr/hsr_framereg.c
> index 865eda39d601..b77f1189d19d 100644
> --- a/net/hsr/hsr_framereg.c
> +++ b/net/hsr/hsr_framereg.c
> @@ -415,7 +415,7 @@ void hsr_addr_subst_dest(struct hsr_node *node_src, struct sk_buff *skb,
>         node_dst = find_node_by_addr_A(&port->hsr->node_db,
>                                        eth_hdr(skb)->h_dest);
>         if (!node_dst) {
> -               if (net_ratelimit() && port->hsr->prot_version != PRP_V1)
> +               if (port->hsr->prot_version != PRP_V1 && net_ratelimit())
>                         netdev_err(skb->dev, "%s: Unknown node\n", __func__);
>                 return;
>         }
> 
> ---
> base-commit: 75014826d0826d175aa9e36cd8e118793263e3f4
> change-id: 20230315-net-20230315-hsr_framereg-ratelimit-3c8ff6e43511
> 
> Best regards,
> --
> Matthieu Baerts <matthieu.baerts@...sares.net>
> 

BR
Steen