netdev - Re: [PATCH v1] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2023 17:54:37 +0800
From:   Yun-hao Chung <howardchung@...gle.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     linux-bluetooth@...r.kernel.org, marcel@...tmann.org,
        chromeos-bluetooth-upstreaming@...omium.org,
        Archie Pusaka <apusaka@...omium.org>,
        Brian Gix <brian.gix@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v1] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

Thanks for the reply!
A new patch has been sent.
Please take a look when available.

Thanks,
Howard


On Thu, Mar 16, 2023 at 5:47 PM Paul Menzel <pmenzel@...gen.mpg.de> wrote:
>
> Dear Howard,
>
>
> Thank you for your patch.
>
> Am 16.03.23 um 08:10 schrieb Howard Chung:
> > From: howardchung <howardchung@...gle.com>
>
> Please configure your full name:
>
>      git config --global user.name "Howard Chung"
>      git commit -s --amend --author="Howard Chung <howardchung@...gle.com>"
>
> > The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable
> > length argumenent. This patch adds right the field.
>
> argument
>
> Were you seeing actual problems? If so, please describe the test setup.
>
> > Reviewed-by: Archie Pusaka <apusaka@...omium.org>
> > Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
> > Signed-off-by: howardchung <howardchung@...gle.com>
> > ---
> >
> >   net/bluetooth/mgmt.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> > index 39589f864ea7..249dc6777fb4 100644
> > --- a/net/bluetooth/mgmt.c
> > +++ b/net/bluetooth/mgmt.c
> > @@ -9357,7 +9357,8 @@ static const struct hci_mgmt_handler mgmt_handlers[] = {
> >       { add_ext_adv_data,        MGMT_ADD_EXT_ADV_DATA_SIZE,
> >                                               HCI_MGMT_VAR_LEN },
> >       { add_adv_patterns_monitor_rssi,
> > -                                MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE },
> > +                                MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE,
> > +                                             HCI_MGMT_VAR_LEN },
> >       { set_mesh,                MGMT_SET_MESH_RECEIVER_SIZE,
> >                                               HCI_MGMT_VAR_LEN },
> >       { mesh_features,           MGMT_MESH_READ_FEATURES_SIZE },
>
> Acked-by: Paul Menzel <pmenzel@...gen.mpg.de>
>
>
> Kind regards,
>
> Paul