netdev - Re: [PATCH v2] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2023 11:02:58 +0100
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Howard Chung <howardchung@...gle.com>
Cc:     linux-bluetooth@...r.kernel.org, marcel@...tmann.org,
        chromeos-bluetooth-upstreaming@...omium.org,
        Archie Pusaka <apusaka@...omium.org>,
        Brian Gix <brian.gix@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

Dear Yun-hao,


Am 16.03.23 um 10:53 schrieb Howard Chung:
> The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable
> length argumenent. This patch adds right the field.

There is still the typo in argument.

> Reviewed-by: Archie Pusaka <apusaka@...omium.org>
> Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
> Signed-off-by: Howard Chung <howardchung@...gle.com>
> ---
> Hi upstream maintainers,
> Host is not able to register advmon with rssi due to the bug.
> This patch has been locally tested by adding monitor with rssi via
> btmgmt on a kernel 6.1 machine.

I would add that information to the commit message.

[…]


Kind regards,

Paul