netdev - RE: [PATCH net-next V3] dt-bindings: net: ethernet-controller: Add ptp-hardware-clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW5PR12MB55988A6BACF98A29391CF64D87BC9@MW5PR12MB5598.namprd12.prod.outlook.com>
Date:   Thu, 16 Mar 2023 10:53:44 +0000
From:   "Gaddam, Sarath Babu Naidu" <sarath.babu.naidu.gaddam@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>
CC:     "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "yangbo.lu@....com" <yangbo.lu@....com>,
        "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>,
        "Sarangi, Anirudha" <anirudha.sarangi@....com>,
        "Katakam, Harini" <harini.katakam@....com>,
        "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH net-next V3] dt-bindings: net: ethernet-controller: Add
 ptp-hardware-clock



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Tuesday, March 14, 2023 9:16 PM
> To: Gaddam, Sarath Babu Naidu
> <sarath.babu.naidu.gaddam@....com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> robh+dt@...nel.org; richardcochran@...il.com
> Cc: krzysztof.kozlowski+dt@...aro.org; netdev@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> yangbo.lu@....com; Pandey, Radhey Shyam
> <radhey.shyam.pandey@....com>; Sarangi, Anirudha
> <anirudha.sarangi@....com>; Katakam, Harini
> <harini.katakam@....com>; git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH net-next V3] dt-bindings: net: ethernet-controller:
> Add ptp-hardware-clock
> 
> On 08/03/2023 06:44, Sarath Babu Naidu Gaddam wrote:
> > There is currently no standard property to pass PTP device index
> > information to ethernet driver when they are independent.
> >
> > ptp-hardware-clock property will contain phandle to PTP clock node.
> >
> > Its a generic (optional) property name to link to PTP phandle to
> > Ethernet node. Any future or current ethernet drivers that need a
> > reference to the PHC used on their system can simply use this generic
> > property name instead of using custom property implementation in
> their
> > device tree nodes."
> >
> > Signed-off-by: Sarath Babu Naidu Gaddam
> > <sarath.babu.naidu.gaddam@....com>
> > Acked-by: Richard Cochran <richardcochran@...il.com>
> > ---
> >
> > Freescale driver currently has this implementation but it will be good
> > to agree on a generic (optional) property name to link to PTP phandle
> > to Ethernet node. In future or any current ethernet driver wants to
> > use this method of reading the PHC index,they can simply use this
> > generic name and point their own PTP clock node, instead of creating
> > separate property names in each ethernet driver DT node.
> 
> Again, I would like to see an user of this. I asked about this last time and
> nothing was provided.
> 
> So basically you send the same thing hoping this time will be accepted...

Apologies for miscommunication. As of now, we see only freescale driver
has this type of implementation but with different binding name. we do 
not have the hardware to test this. However, I am going to upstream PTP
support in AMD/Xilinx axiethernet driver that will be user of this binding.

 I will pick up on this binding again along with consumer driver and address
 your review comments.     

Thanks for the review.

Thanks,
Sarath