netdev - Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2023 12:35:58 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Guo Samin <samin.guo@...rfivetech.com>,
        linux-riscv@...ts.infradead.org, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Emil Renner Berthing <kernel@...il.dk>,
        Richard Cochran <richardcochran@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Peter Geis <pgwipeout@...il.com>,
        Yanhong Wang <yanhong.wang@...rfivetech.com>,
        Tommaso Merciai <tomm.merciai@...il.com>
Subject: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac

On 16/03/2023 11:18, Guo Samin wrote:
> 
> 
> -------- 原始信息 --------
> Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> to : Guo Samin <samin.guo@...rfivetech.com>, linux-riscv@...ts.infradead.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
> data: 2023/3/16
> 
>> On 16/03/2023 09:28, Guo Samin wrote:
>>>
>>>
>>> -------- 原始信息 --------
>>> 主题: Re: [PATCH v7 4/6] dt-bindings: net: Add support StarFive dwmac
>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> 收件人: Guo Samin <samin.guo@...rfivetech.com>, linux-riscv@...ts.infradead.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
>>> 日期: 2023/3/16
>>>
>>>> On 16/03/2023 09:15, Guo Samin wrote:
>>>>>>>> interrupts: ???
>>>>>>>>
>>>>>>>
>>>>>>> Hi Krzysztof, 
>>>>>>>
>>>>>>> snps,dwmac.yaml has defined the reg/interrupt/interrupt-names nodes,
>>>>>>> and the JH7110 SoC is also applicable.
>>>>>>> Maybe just add reg/interrupt/interrupt-names to the required ?
>>>>>>
>>>>>> You need to constrain them.
>>>>>
>>>>>
>>>>> I see. I will add reg constraints in the next version, thanks.
>>>>>
>>>>> I have one more question, the interrupts/interrup-names of JH7110 SoC's gmac are exactly the same as snps,dwmac.yaml,
>>>>> do these also need to be constrained?
>>>>
>>>> The interrupts on common binding are variable, so you need to constrain
>>>> them - you have fixed number of them, right?
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>
>>> Yes, JH7110 fixed is 3 pcs. Thanks, I will constrain them.
>>
>> Then just minItems: 3, maxItems: 3 here should be enough
>>
>> Best regards,
>> Krzysztof
>>
> 
> Hi Krzysztof,
> 
> Thank you for the suggestion. 
> I'll change it like this in the next version, is right?

Yes, looks good for me.

Best regards,
Krzysztof