netdev - Re: [PATCH net 3/3] iavf: do not track VLAN 0 filters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2023 07:15:32 -0600
From:   Ahmed Zaki <ahmed.zaki@...el.com>
To:     Leon Romanovsky <leon@...nel.org>,
        Tony Nguyen <anthony.l.nguyen@...el.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>, <netdev@...r.kernel.org>,
        Michal Kubiak <michal.kubiak@...el.com>,
        Rafal Romanowski <rafal.romanowski@...el.com>
Subject: Re: [PATCH net 3/3] iavf: do not track VLAN 0 filters


On 2023-03-15 02:48, Leon Romanovsky wrote:
> On Tue, Mar 14, 2023 at 10:44:23AM -0700, Tony Nguyen wrote:
>> From: Ahmed Zaki <ahmed.zaki@...el.com>
>>
>> When an interface with the maximum number of VLAN filters is brought up,
>> a spurious error is logged:
>>
>>      [257.483082] 8021q: adding VLAN 0 to HW filter on device enp0s3
>>      [257.483094] iavf 0000:00:03.0 enp0s3: Max allowed VLAN filters 8. Remove existing VLANs or disable filtering via Ethtool if supported.
>>
>> The VF driver complains that it cannot add the VLAN 0 filter.
>>
>> On the other hand, the PF driver always adds VLAN 0 filter on VF
>> initialization. The VF does not need to ask the PF for that filter at
>> all.
>>
>> Fix the error by not tracking VLAN 0 filters altogether. With that, the
>> check added by commit 0e710a3ffd0c ("iavf: Fix VF driver counting VLAN 0
>> filters") in iavf_virtchnl.c is useless and might be confusing if left as
>> it suggests that we track VLAN 0.
>>
>> Fixes: 0e710a3ffd0c ("iavf: Fix VF driver counting VLAN 0 filters")
>> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
>> Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>
>> Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>
>> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
>> ---
>>   drivers/net/ethernet/intel/iavf/iavf_main.c     | 4 ++++
>>   drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 2 --
>>   2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
>> index 3273aeb8fa67..eb8f944276ff 100644
>> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
>> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
>> @@ -893,6 +893,10 @@ static int iavf_vlan_rx_add_vid(struct net_device *netdev,
>>   {
>>   	struct iavf_adapter *adapter = netdev_priv(netdev);
>>   
>> +	/* Do not track VLAN 0 filter, always added by the PF on VF init */
>> +	if (!vid)
>> +		return 0;
> I would expect similar check in iavf_vlan_rx_kill_vid(),
>
> Thanks

Thanks for review. Next version will include the check in 
iavf_vlan_rx_kill_vid()

>
>> +
>>   	if (!VLAN_FILTERING_ALLOWED(adapter))
>>   		return -EIO;
>>   
>> diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> index 6d23338604bb..4e17d006c52d 100644
>> --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
>> @@ -2446,8 +2446,6 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter,
>>   		list_for_each_entry(f, &adapter->vlan_filter_list, list) {
>>   			if (f->is_new_vlan) {
>>   				f->is_new_vlan = false;
>> -				if (!f->vlan.vid)
>> -					continue;
>>   				if (f->vlan.tpid == ETH_P_8021Q)
>>   					set_bit(f->vlan.vid,
>>   						adapter->vsi.active_cvlans);
>> -- 
>> 2.38.1
>>