netdev - Re: [PATCH net v2 7/8] net/mlx5e: take into account device reconfiguration for xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZBKC8lxQurwQpj4k@x130>
Date:   Wed, 15 Mar 2023 19:46:10 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
        hawk@...nel.org, john.fastabend@...il.com, saeedm@...dia.com,
        leon@...nel.org, shayagr@...zon.com, akiyano@...zon.com,
        darinzon@...zon.com, sgoutham@...vell.com,
        lorenzo.bianconi@...hat.com, toke@...hat.com, teknoraver@...a.com,
        ttoukan.linux@...il.com
Subject: Re: [PATCH net v2 7/8] net/mlx5e: take into account device
 reconfiguration for xdp_features flag

On 15 Mar 17:29, Jakub Kicinski wrote:
>On Wed, 15 Mar 2023 16:39:00 -0700 Jakub Kicinski wrote:
>> diff --git a/net/core/xdp.c b/net/core/xdp.c
>> index 87e654b7d06c..5722a1fc6e9e 100644
>> --- a/net/core/xdp.c
>> +++ b/net/core/xdp.c
>> @@ -781,6 +781,9 @@ void xdp_set_features_flag(struct net_device *dev, xdp_features_t val)
>>                 return;
>>
>>         dev->xdp_features = val;
>> +
>> +       if (dev->reg_state < NETREG_REGISTERED)
>> +               return;
>>         call_netdevice_notifiers(NETDEV_XDP_FEAT_CHANGE, dev);
>>  }
>>  EXPORT_SYMBOL_GPL(xdp_set_features_flag);
>>
>> ? The notifiers are not needed until the device is actually live.
>
>I think so.. let me send a full patch.

We have an  internal version of a fix, Tariq is finalizing some review
comments and we will be posting it ASAP.