netdev - [RFC/RFT PATCH net-next 0/4] KSZ DSA driver: xMII speed adjustment and partial reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230316161250.3286055-1-vladimir.oltean@nxp.com>
Date:   Thu, 16 Mar 2023 18:12:46 +0200
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Arun Ramadoss <arun.ramadoss@...rochip.com>,
        Russell King <linux@...linux.org.uk>,
        Marek Vasut <marex@...x.de>,
        Oleksij Rempel <linux@...pel-privat.de>,
        linux-kernel@...r.kernel.org
Subject: [RFC/RFT PATCH net-next 0/4] KSZ DSA driver: xMII speed adjustment and partial reg_fields conversion

Hi,

Yesterday I picked up this patch and resubmitted it:
https://patchwork.kernel.org/project/netdevbpf/patch/20230222031738.189025-1-marex@denx.de/
here:
https://patchwork.kernel.org/project/netdevbpf/patch/20230315231916.2998480-1-vladimir.oltean@nxp.com/

and today I'm trying to address the rest of the points brought up in
that conversation, namely:

- commit c476bede4b0f ("net: dsa: microchip: ksz8795: use common xmii
  function") stopped adjusting the xMII port speed on KSZ8795, does it
  still work? No idea. Patch 3/4 deals with that.

- Mapping P_XMII_CTRL_0 and P_XMII_CTRL_1 to the same value on KSZ8795
  raised some eyebrows, and some reading shows that it is also partially
  incorrect (see patch 2/4). This is also where I propose to convert to
  reg_fields.

As it turns out, patch 2/4 is a dependency for patch 3/4, even if 3/4
may be a fix.

Patch 1/4 is a dependency of 2/4.

Patch 4/4 is something I also noticed during review. I left it at the
end so that it won't conflict with something that could reasonably be
submitted as a bug fix.

ABSOLUTELY NO TESTING WAS DONE. I don't have the hardware.

THIS BREAKS EVERYTHING EXCEPT FOR KSZ8795. Any testers should test on
that if possible (due to both patches 2/4, and 3/4).

Vladimir Oltean (4):
  net: dsa: microchip: add an enum for regmap widths
  net: dsa: microchip: partial conversion to regfields API for KSZ8795
    (WIP)
  net: dsa: microchip: allow setting xMII port speed/duplex on
    KSZ8765/KSZ8794/KSZ8795
  net: dsa: microchip: remove unused dev->dev_ops->phylink_mac_config()

 drivers/net/dsa/microchip/ksz8795.c      |  45 ++--
 drivers/net/dsa/microchip/ksz8863_smi.c  |  11 +-
 drivers/net/dsa/microchip/ksz9477.c      |  24 +--
 drivers/net/dsa/microchip/ksz9477_i2c.c  |  11 +-
 drivers/net/dsa/microchip/ksz_common.c   | 256 +++++++++++++----------
 drivers/net/dsa/microchip/ksz_common.h   | 110 +++++++---
 drivers/net/dsa/microchip/ksz_spi.c      |   6 +-
 drivers/net/dsa/microchip/lan937x_main.c |   8 +-
 8 files changed, 299 insertions(+), 172 deletions(-)

-- 
2.34.1