netdev - Re: [PATCH] net: macb: Set MDIO clock divisor for pclk higher than 160MHz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f3d0f2c-8bf9-41aa-8a7f-79407753df3b@lunn.ch>
Date:   Thu, 16 Mar 2023 20:34:45 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Bartosz Wawrzyniak <bwawrzyn@...co.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, nicolas.ferre@...rochip.com,
        claudiu.beznea@...rochip.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, xe-linux-external@...co.com,
        danielwa@...co.com, olicht@...co.com, mawierzb@...co.com
Subject: Re: [PATCH] net: macb: Set MDIO clock divisor for pclk higher than
 160MHz

On Thu, Mar 16, 2023 at 10:03:39AM +0000, Bartosz Wawrzyniak wrote:
> Currently macb sets clock divisor for pclk up to 160 MHz.
> Function gem_mdc_clk_div was updated to enable divisor
> for higher values of pclk.
> 
> Signed-off-by: Bartosz Wawrzyniak <bwawrzyn@...co.com>
> ---
>  drivers/net/ethernet/cadence/macb.h      | 2 ++
>  drivers/net/ethernet/cadence/macb_main.c | 6 +++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index 14dfec4db8f9..c1fc91c97cee 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -692,6 +692,8 @@
>  #define GEM_CLK_DIV48				3
>  #define GEM_CLK_DIV64				4
>  #define GEM_CLK_DIV96				5
> +#define GEM_CLK_DIV128				6
> +#define GEM_CLK_DIV224				7

Do these divisors exist for all variants? I'm just wondering why these
are being added now, rather than back in 2011-03-09.

   Andrew