netdev - Re: [PATCH net v2 1/2] ravb: avoid PHY being resumed when interface is not up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78e0a047-ad0a-2ca6-10f7-9734a191cefd@gmail.com>
Date:   Thu, 16 Mar 2023 13:01:47 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        netdev@...r.kernel.org
Cc:     linux-renesas-soc@...r.kernel.org,
        Heiner Kallweit <hkallweit1@...il.com>,
        Michal Kubiak <michal.kubiak@...el.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2 1/2] ravb: avoid PHY being resumed when interface
 is not up

On 3/15/23 00:41, Wolfram Sang wrote:
> RAVB doesn't need mdiobus suspend/resume, that's why it sets
> 'mac_managed_pm'. However, setting it needs to be moved from init to
> probe, so mdiobus PM functions will really never be called (e.g. when
> the interface is not up yet during suspend/resume).
> 
> Fixes: 4924c0cdce75 ("net: ravb: Fix PHY state warning splat during system resume")
> Suggested-by: Heiner Kallweit <hkallweit1@...il.com>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Reviewed-by: Michal Kubiak <michal.kubiak@...el.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

This is a pattern that a lot of drivers have, for better or for worse, 
it would be neat if we couldcome up with a common helper that could work 
mostly with OF configurations, what do you think?
-- 
Florian