netdev - Re: [net-next 05/15] net/mlx5e: Correct SKB room check to use all room in the fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Mar 2023 21:59:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: Re: [net-next 05/15] net/mlx5e: Correct SKB room check to use all
 room in the fifo

On Wed, 15 Mar 2023 21:56:41 -0700 Jakub Kicinski wrote:
> On Mon, 13 Mar 2023 22:42:24 -0700 Saeed Mahameed wrote:
> > Subject: [net-next 05/15] net/mlx5e: Correct SKB room check to use all room in the fifo  
> 
> net/mlx5e: utilize the entire fifo
> 
> > From: Rahul Rameshbabu <rrameshbabu@...dia.com>
> > 
> > Previous check was comparing against the fifo mask. The mask is size of the
> > fifo (power of two) minus one, so a less than or equal comparator should be
> > used for checking if the fifo has room for the SKB.
> > 
> > Fixes: 19b43a432e3e ("net/mlx5e: Extend SKB room check to include PTP-SQ")  
> 
> no fixes tag
> 
> I thought we've been over this.

The rest looks fine, do you want me to apply from the list and fix up?