netdev - Re: [BUG] mt7986 doesn't allow to re-enable ethsys clock gates after they have been disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2023 12:11:58 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Eugene Konev <uejikov@...il.com>,
        linux-mediatek@...ts.infradead.org
Cc:     Frank Wunderlich <frank-w@...lic-files.de>,
        Daniel Golle <daniel@...rotopia.org>,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [BUG] mt7986 doesn't allow to re-enable ethsys clock gates after
 they have been disabled

+CC relevant people.

Hi Eugene,

On 12/03/2023 02:25, Eugene Konev wrote:
> When ethsys clocks (eth_fe_en, eth_gp1_en, eth_gp2_en, eth_wocpu1_en and
> eth_wocpu0_en) are disabled calling clk_enable on them doesn't enable them
> again (appropriate bits in the register stay 0).
> This prevents using mtk_eth as module, because kernel disables all unclaimed
> clocks with clk_disable_unused.
> 

Is this a regression? Were you able to bisect the issue to see which commit 
introduced this behavior?

Regards,
Matthias