netdev - Re: [PATCH net] net: atlantic: Fix crash when XDP is enabled but no program is loaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167901361801.32704.18387361961611425279.git-patchwork-notify@kernel.org>
Date:   Fri, 17 Mar 2023 00:40:18 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Toke Høiland-Jørgensen <toke@...hat.com>@ci.codeaurora.org
Cc:     irusskikh@...vell.com, ast@...nel.org, daniel@...earbox.net,
        davem@...emloft.net, kuba@...nel.org, hawk@...nel.org,
        john.fastabend@...il.com, ap420073@...il.com,
        Freysteinn.Alfredsson@....se, edumazet@...gle.com,
        pabeni@...hat.com, netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH net] net: atlantic: Fix crash when XDP is enabled but no
 program is loaded

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 15 Mar 2023 13:55:38 +0100 you wrote:
> The aq_xdp_run_prog() function falls back to the XDP_ABORTED action
> handler (using a goto) if the operations for any of the other actions fail.
> The XDP_ABORTED handler in turn calls the bpf_warn_invalid_xdp_action()
> tracepoint. However, the function also jumps into the XDP_PASS helper if no
> XDP program is loaded on the device, which means the XDP_ABORTED handler
> can be run with a NULL program pointer. This results in a NULL pointer
> deref because the tracepoint dereferences the 'prog' pointer passed to it.
> 
> [...]

Here is the summary with links:
  - [net] net: atlantic: Fix crash when XDP is enabled but no program is loaded
    https://git.kernel.org/netdev/net/c/37d010399f75

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html