netdev - Re: [PATCH net] gve: Cache link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2023 17:42:27 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     joshwash@...gle.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net] gve: Cache link_speed value from device

On Wed, 15 Mar 2023 10:40:16 -0700 joshwash@...gle.com wrote:
> From: Joshua Washington <joshwash@...gle.com>
> 
> The link speed is never changed for the uptime of a VM. Caching the
> value will allow for better performance.
> 
> Fixes: 7e074d5a76ca ("gve: Enable Link Speed Reporting in the driver.")

If it needs to go in as a fix / to stable we need a bit more info about
the nature of the problem. What user-visible (or hypervisor-visible)
impact will be?  What entity needs link info so often that it becomes
a problem?

The code looks fine as an optimization, i.e. for net-next, but you say
"PATCH net" and there's a Fixes tag...